Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Local Avatars TypeError in PHP8 #692

Open
mattwatsoncodes opened this issue Jan 9, 2023 · 1 comment · Fixed by #695
Open

Simple Local Avatars TypeError in PHP8 #692

mattwatsoncodes opened this issue Jan 9, 2023 · 1 comment · Fixed by #695

Comments

@mattwatsoncodes
Copy link

This line produces an error in PHP8:

altis-cms/lib/simple-local-avatars/includes/class-simple-local-avatars.php

Line 928 in d8348f1

if ( is_int( $url_or_media_id + 0 ) ) { 

TypeError: Unsupported operand types: string + int

Using is_numeric instead of the additional of a 0 and is_int fixes the error.

PR raised in 10up repository to fix this issue:

10up/simple-local-avatars#183
@owaincuvelier
Copy link

hey @mattwatsoncodes, just to let you know this is getting fixed in: #695

@owaincuvelier owaincuvelier linked a pull request Jan 23, 2023 that will close this issue
Fix a PHP8 TypeError in 10up/simple-local-avatars #695
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a PHP8 TypeError in 10up/simple-local-avatars humanmade/altis-cms
2 participants
@owaincuvelier @mattwatsoncodes