You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have a max-nesting rule that is very strict at only allowing 2 levels of nesting with scss, with the exception of blockless-at-rules. I think it might be beneficial to loosen this just a bit for @media rules by adding "ignoreAtRules": ["media"] to the general rule in Stylelint.
Stylelint currently already ignores @media at the first level in a nesting pattern when parsing for nesting depth, but it does not ignore @media when it resides down the chain. If we make the proposed change, @media levels will not affect the nesting depth evaluation, and we still shouldn't end up with too-specific of selectors.
Hhhmmm that might be a problem, yes. I mis-read that rule originally but testing it more it does seem to ignore anything under the media query and not just the level the media query is at.
Currently, we have a
max-nesting
rule that is very strict at only allowing 2 levels of nesting withscss
, with the exception ofblockless-at-rules
. I think it might be beneficial to loosen this just a bit for@media
rules by adding"ignoreAtRules": ["media"]
to the general rule in Stylelint.Stylelint currently already ignores
@media
at the first level in a nesting pattern when parsing for nesting depth, but it does not ignore@media
when it resides down the chain. If we make the proposed change,@media
levels will not affect the nesting depth evaluation, and we still shouldn't end up with too-specific of selectors.Thoughts?
cc @peterwilsoncc @sambulance @goldenapples @rmccue @joemcgill @kirstyburgoine
The text was updated successfully, but these errors were encountered: