-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPCS/I18n refactor breaks HM-Minimum on PHP 8.2 #308
Comments
Thanks! I've fixed this in #314 as part of our phpcs upgrade. |
@rmccue that's great to hear! We ended up forking this repo and bringing it all up to speed for PHP 8.2 as I didn't think it was being maintained anymore. Excited to see these updates come through 😄 |
We use it every day on many projects, we've just been slow to update to PHP 8.2 due to WP's compatibility with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WPCS recently deprecated a temporary property called
check_translator_comments
that is currently being used in the HM-Minimum ruleset.Commit details here: WordPress/WordPress-Coding-Standards@31064cf
Affected code is here:
coding-standards/HM-Minimum/ruleset.xml
Lines 160 to 163 in e8ec095
I think the solution is as easy as:
The text was updated successfully, but these errors were encountered: