Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor chain endpoint structure #104

Closed
fengtality opened this issue May 11, 2023 · 5 comments · Fixed by #105
Closed

Refactor chain endpoint structure #104

fengtality opened this issue May 11, 2023 · 5 comments · Fixed by #105
Assignees
@vic-en
Labels
bounty refactor

Comments

@fengtality
Copy link
Contributor

fengtality commented May 11, 2023 •
edited
Loading

Description

  • Currently, chain-specific endpoints are in folders in the main directory, ie. /evm/ and /near
  • These endpoints are duplicative and will be difficult to maintain in the future
  • Refactor the endpoints so that there is only a single /chain/ set of endpoints
  • Each endpoint request should include a chain parameter
  • Raise NotImplemented for chains that don't implement that particular endpoint
  • Modify unit tests

Bounty

  • Sponsor: Hummingbot Foundation
  • Bounty amount: 50,000 HBOT (P2)
  • Developer portion: 100%
  • Status: OPEN
@carlitogetaladajr
Copy link

This issue was assigned to @vic-en. Thank you for your contribution!

@rapcmia rapcmia linked a pull request May 22, 2023 that will close this issue
refactor / connectors statuses #105
Merged
2 tasks
@nikspz
Copy link
Contributor

nikspz commented May 31, 2023

Thanks for your participation, the bounty has been sent to @vic-en . The fix has been deployed on development branch and hummingbot version 1.16.0

@nikspz nikspz closed this as completed May 31, 2023
@fengtality fengtality reopened this Jun 20, 2023
@fengtality
Copy link
Contributor Author

reopening as it was paid prematurely and @vic-en is still working on this PR

@fengtality fengtality mentioned this issue Jun 30, 2023
Merged
@vic-en
Copy link
Collaborator

vic-en commented Jul 5, 2023

@fengtality
PRS are hummingbot/hummingbot#6445 and #147 on the HB Client and Gateway respectively.

@nikspz
Copy link
Contributor

nikspz commented Jul 6, 2023

Thanks for your participation, the bounty has been sent to @vic-en . PRs hummingbot/hummingbot#6445 and #147 merged on development branch and hummingbot version 1.18.0

@nikspz nikspz closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vic-en vic-en

Labels
bounty refactor
Projects
Bounties Board
Status: Paid
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor / connectors statuses CoinAlpha/gateway
4 participants
@fengtality @vic-en @nikspz @carlitogetaladajr