UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) #154

nikspz · 2023-07-12T12:55:12Z

Describe the bug
UniswapLP - failed to remove liquidity

Steps To Reproduce
0. You Have added liquidity with id 123456

Clone and install latest development Client + gateway
set it up gateway to ONLINE with generate certs and yarn start
connect uniswap arbitrum_one
set up GATEWAY_CERT, GATEWAY_KEY and ETH_ADDRESS
change eth_uniswap_position network to arbitrum_one and tokenId to 123456
execute curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_position.json)" https://localhost:15888/amm/liquidity/remove | jq

Actual:
Failed to remove liquidity with error:

"httpErrorCode": 503,
  "errorCode": 1099,
  "stack": "Error: One of the tokens in this position isn't recognized. $token0: undefined, $token1: undefined\n    at UniswapLP.<anonymous> (/home/nikita/gwtest1/dist/src/connectors/uniswap/uniswap.lp.helper.js:285:23)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/nikita/gwtest1/dist/src/connectors/uniswap/uniswap.lp.helper.js:28:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"

Release version
dev-1.18.0

The text was updated successfully, but these errors were encountered:

fengtality · 2023-07-12T13:57:52Z

@nikspz Can you provide more info about the position you added and tried to remove?

transaction hash for the add position tx?
more info about the position created (tokens, address, etc)

nikspz · 2023-07-12T14:12:22Z

@fengtality position added:
ID: 719721
Txhash: https://arbiscan.io/tx/0xbdb5878f9c30c9229783296e7241023e59fa27459e47635582398bdb3840686b

gateway logs: logs_gateway_app.log

2023-07-12 06:57:51 | info | 	Requesting balance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:57:51 | info | 	Raw balance of 0x912ce59144191c1204e64559fe8253a0e49e6548 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 9925517082389357311 | undefined
2023-07-12 06:57:51 | info | 	Raw balance of 0x82af49447d8a07e3bd95bd0d56f35241523fbab1 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 6700060766820287 | undefined
2023-07-12 06:57:54 | info | 	Requesting balance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:57:54 | info | 	Requesting balance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:57:55 | info | 	Raw balance of 0x912ce59144191c1204e64559fe8253a0e49e6548 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 9925517082389357311 | undefined
2023-07-12 06:57:55 | info | 	Raw balance of 0x82af49447d8a07e3bd95bd0d56f35241523fbab1 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 6700060766820287 | undefined
2023-07-12 06:58:03 | info | 	Requesting spender 0xC36442b4a4522E871399CD717aBDD847Ab11FE88 allowance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:03 | info | 	Requesting spender 0xC36442b4a4522E871399CD717aBDD847Ab11FE88 allowance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:03 | info | 	Requesting spender 0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45 allowance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:03 | info | 	Requesting spender 0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45 allowance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:04 | info | 	115792089237316195423570985008687907853269984665640564039457584007913129639935 | undefined
2023-07-12 06:58:04 | info | 	9925517082389357311 | undefined
2023-07-12 06:58:04 | info | 	115792089237316195423570985008687907853269984665640564039457558134370683127830 | undefined
2023-07-12 06:58:04 | info | 	115792089237316195423570985008687907853269984665640564039457584007913129639935 | undefined
2023-07-12 06:58:04 | info | 	Requesting balance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:04 | info | 	Requesting balance for owner 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843. | undefined
2023-07-12 06:58:04 | info | 	Raw balance of 0x82af49447d8a07e3bd95bd0d56f35241523fbab1 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 6700060766820287 | undefined
2023-07-12 06:58:04 | info | 	Raw balance of 0x912ce59144191c1204e64559fe8253a0e49e6548 for 0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843: 9925517082389357311 | undefined
2023-07-12 06:58:08 | info | 	Uniswap V3 Add position Tx Hash: 0xbdb5878f9c30c9229783296e7241023e59fa27459e47635582398bdb3840686b | undefined
2023-07-12 06:58:08 | info | 	Liquidity added, txHash is 0xbdb5878f9c30c9229783296e7241023e59fa27459e47635582398bdb3840686b, nonce is 377, gasPrice is 0.1. | undefined
2023-07-12 06:58:08 | info | 	Poll arbitrum_one, txHash 0xbdb5878f9c30c9229783296e7241023e59fa27459e47635582398bdb3840686b, status 1. | undefined
2023-07-12 06:58:09 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:10 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:11 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:12 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:13 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:14 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:15 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:16 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:17 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-07-12 06:58:18 | error | 	One of the tokens in this position isn't recognized. | Error: One of the tokens in this position isn't recognized.
    at UniswapLP.<anonymous> (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:76:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/nikita/gwfixlp/dist/src/connectors/uniswap/uniswap.lp.js:28:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Curl command to remove:

curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_position.json)" https://localhost:15888/amm/liquidity/remove | jq

eth_uniswap_position.json

{
  "address": "$ETH_ADDRESS",
  "tokenId": 719721,
  "chain": "ethereum",
  "network": "arbitrum_one",
  "connector": "uniswapLP"
}

nikspz · 2023-07-12T14:16:52Z

tokens:
ARB:
{
"chainId":42161,
"address":"0x912ce59144191c1204e64559fe8253a0e49e6548",
"name":"Arbitrum",
"symbol":"ARB",
"decimals":18,
"logoURI":"https://assets.coingecko.com/coins/images/16547/thumb/photo_2023-03-29_21.47.00.jpeg?1680097630"
}

WETH:

{
"chainId":42161,
"address":"0x82af49447d8a07e3bd95bd0d56f35241523fbab1",
"name":"WETH",
"symbol":"WETH",
"decimals":18,
"logoURI":"https://assets.coingecko.com/coins/images/2518/thumb/weth.png?1628852295"
},

nikspz · 2023-07-13T04:54:00Z

get position request:

curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_position.json)" https://localhost:15888/amm/liquidity/position | jq

get pool price:


curl -s -X POST -k --key $GATEWAY_KEY --cert $GATEWAY_CERT -H "Content-Type: application/json" -d "$(envsubst < ./requests/eth_uniswap_pool_price.json)" https://localhost:15888/amm/liquidity/price | jq

0x82aF49447D8a07e3bd95BD0d56f35241523fBab1 (https://arbiscan.io/address/0x82aF49447D8a07e3bd95BD0d56f35241523fBab1)
0x912CE59144191C1204E64559FE8253a0e49E6548 (https://arbiscan.io/address/0x912CE59144191C1204E64559FE8253a0e49E6548)

uniswapLP Client strategy status

fengtality · 2023-07-13T22:55:09Z

Bounty

Description: Fix the UniswapLP connector code so that removing liquidity works
Sponsor: Hummingbot Foundation
Bounty Rationale: Uniswap is the Gold DEX connector for Epoch 5
Bounty Amount: 50,000 HBOT (P2)
Developer Payment: 50,000 HBOT (100%)
Status: Open

@vic-en Can you take this bounty? I think this issue may be related to the chain configuration change, since the call to getTokenByAddress now returns undefined in https://github.com/hummingbot/gateway/blob/main/src/connectors/uniswap/uniswap.lp.ts#L74.

ZAABY · 2023-07-16T19:03:15Z

Bounty

Description: Fix the UniswapLP connector code so that removing liquidity works

Sponsor: Hummingbot Foundation

Bounty Rationale: Uniswap is the Gold DEX connector for Epoch 5

Bounty Amount: 50,000 HBOT (P2)

Developer Payment: 50,000 HBOT (100%)

Status: Open

@vic-en Can you take this bounty? I think this issue may be related to the chain configuration change, since the call to getTokenByAddress now returns undefined in https://github.com/hummingbot/gateway/blob/main/src/connectors/uniswap/uniswap.lp.ts#L74.

Bounty Accepted!

nikspz · 2023-07-17T13:45:53Z

Assigned to @ZAABY , please be informed:

Since you’re assigned to this bounty exclusively, please keep us informed on your progress over the next few days
Let us know if you don’t have time, and we will unassigned and keep it open for other devs
Only one dev can be assigned to one bounty

Thanks for your contribution!

ZAABY · 2023-07-17T19:37:51Z

So, from my understanding till now I have traced back the error to get contact function. I think this is were the problem is. So, I am giving a try to get gateway interact directly with the pool instead of via router (Which it's doing rn!)

ZAABY · 2023-07-19T21:27:31Z

Hello Everyone!
So I came to some solution but facing the attached error. Can any one help me what to do to get out of it?

fengtality · 2023-07-19T21:52:49Z

yes it looks like a JS scoping issue as this traces back to the this.storedTokenList call the task is to identity root cause and fix this issue. if you don't have the JS experience to solve this, let me know and we will reassign to a dev with more experience with Gateway

…

On Wed, Jul 19, 2023, 5:27 PM Zohaib Khalid ***@***.***> wrote: Hello Everyone! So I came to some solution but facing the attached error. Can any one help me what to do to get out of it? [image: WhatsApp Image 2023-07-20 at 01 51 50] <https://user-images.githubusercontent.com/96419757/254715082-9170c1d4-7846-453d-9032-f41d1a994bf6.jpeg> — Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANWHVUVGTTJ75QC6OSELL3XRBGM3ANCNFSM6AAAAAA2HOKWPY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ZAABY · 2023-07-21T10:00:58Z

I resign!

nikspz · 2023-07-21T10:04:09Z

@ZAABY unassigned from this bounty

nikspz · 2023-07-21T10:06:27Z

Assigned to @vic-en , please be informed:

Since you’re assigned to this bounty exclusively, please keep us informed on your progress over the next few days
Let us know if you don’t have time, and we will unassigned and keep it open for other devs
Only one dev can be assigned to one bounty

Thanks for your contribution!

nikspz · 2023-07-26T05:17:25Z

fix #169 was merged to the latest development branch

nikspz · 2023-07-31T11:59:25Z

Thanks for your participation, the bounty has been sent to @vic-en. The fix has been deployed on development branch and next hummingbot version 1.19.0

nikspz added bug Something isn't working uniswap-lp labels Jul 12, 2023

nikspz changed the title ~~UniswapLP - failed to remove liquidity~~ UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) Jul 12, 2023

nikspz mentioned this issue Jul 12, 2023

fix/dont use router in uniswaplp #153

Merged

2 tasks

fengtality mentioned this issue Jul 16, 2023

UniswapLP - Error adding liquidity #152

Closed

nikspz assigned ZAABY Jul 17, 2023

nikspz assigned vic-en and unassigned ZAABY Jul 21, 2023

vic-en mentioned this issue Jul 23, 2023

Fix/uniswap token address #169

Merged

2 tasks

nikspz closed this as completed Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) #154

UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) #154

nikspz commented Jul 12, 2023

fengtality commented Jul 12, 2023

nikspz commented Jul 12, 2023 •

edited

Loading

nikspz commented Jul 12, 2023

nikspz commented Jul 13, 2023

fengtality commented Jul 13, 2023 •

edited

Loading

ZAABY commented Jul 16, 2023

Bounty

nikspz commented Jul 17, 2023

ZAABY commented Jul 17, 2023

ZAABY commented Jul 19, 2023

fengtality commented Jul 19, 2023 via email

ZAABY commented Jul 21, 2023

nikspz commented Jul 21, 2023

nikspz commented Jul 21, 2023

nikspz commented Jul 26, 2023

nikspz commented Jul 31, 2023

UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) #154

UniswapLP - failed to remove liquidity (One of the tokens in this position isn't recognized) #154

Comments

nikspz commented Jul 12, 2023

fengtality commented Jul 12, 2023

nikspz commented Jul 12, 2023 • edited Loading

nikspz commented Jul 12, 2023

nikspz commented Jul 13, 2023

fengtality commented Jul 13, 2023 • edited Loading

Bounty

ZAABY commented Jul 16, 2023

Bounty

nikspz commented Jul 17, 2023

ZAABY commented Jul 17, 2023

ZAABY commented Jul 19, 2023

fengtality commented Jul 19, 2023 via email

ZAABY commented Jul 21, 2023

nikspz commented Jul 21, 2023

nikspz commented Jul 21, 2023

nikspz commented Jul 26, 2023

nikspz commented Jul 31, 2023

nikspz commented Jul 12, 2023 •

edited

Loading

fengtality commented Jul 13, 2023 •

edited

Loading