Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway connect LP connectors - Autocomplete for chain displays connected LP connectors #284

Closed
rapcmia opened this issue Feb 20, 2024 · 8 comments
Labels
bug Something isn't working P3

Comments

@rapcmia
Copy link
Contributor

rapcmia commented Feb 20, 2024

Describe the bug
After you successfully connected wallets for a LP connector and decided to add again for a different chain, the autocomplete displays the other LP connectors resulting as option for users to select.

image

image

image

image

This results to errors chain not supported and invalid network when setting up LP connectors

Steps To Reproduce

  1. Add uniswapLP both ethereum and arbitrum chain
  2. Add pancakeswapLP and when selecting chain to connect, press tab or wait for the autocomplete to show

Release version
dev-1.25.0

Attachments
n/a

@rapcmia rapcmia added bug Something isn't working P3 labels Feb 20, 2024
@nikspz
Copy link
Contributor

nikspz commented Feb 20, 2024

Confirmed

connected LPconnectors showed as chains at uniswapLP or PancakeswapLP

image

image

@nikspz nikspz changed the title Gateway connect - Autocomplete displays other connected LP connectors Gateway connect LP connectors - Autocomplete for chain displays connected LP connectors Feb 20, 2024
@nikspz
Copy link
Contributor

nikspz commented Feb 20, 2024

Changed title since showed only for LP connectors
image

@nikspz
Copy link
Contributor

nikspz commented Aug 8, 2024

Reproduced in #340
image

@vic-en
Copy link
Collaborator

vic-en commented Aug 8, 2024

@nikspz I think this is an existing bug. It couldn't have been introduced in my 1 line update pr on the client.

@nikspz
Copy link
Contributor

nikspz commented Aug 12, 2024

Reproduced on dev-2.0.1 version

image

@nikspz
Copy link
Contributor

nikspz commented Aug 12, 2024

Bounty:

  • Sponsor: HB Foundation (Connector pots)
  • Bounty amount: 10K HBOT
  • Developer portion: 10K HBOT

@isreallee82
Copy link
Contributor

i can look into this @nikspz

@cybersecuritylearning
Copy link

cybersecuritylearning commented Aug 13, 2024

I can take a look into this @nikspz

@nikspz nikspz closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
Status: Blocked
Development

No branches or pull requests

5 participants