interp/wazero: add memory debugging and correct Halt() implementation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
force-pushed
the
wazero-interp-halt
branch
3 times, most recently
from
9bf208a
to
59adde8
Compare
Signed-off-by: deadprogram <ron@hybridgroup.com>
deadprogram
force-pushed
the
wazero-interp-halt
branch
from
59adde8
to
99b86b3
Compare
…ources possible from runtime Signed-off-by: deadprogram <ron@hybridgroup.com>
orsinium
approved these changes
Apr 1, 2024
|
Thanks for review @orsinium now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
interp/wazeroby adding the standard memory debugging, and also correcting theHalt()implementation. It should only clear out the module, not the entire engine.