Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic update is breaking xscen and xhydro #64

Closed
1 task
sebastienlanglois opened this issue Dec 22, 2023 · 2 comments
Closed
1 task

Pydantic update is breaking xscen and xhydro #64

sebastienlanglois opened this issue Dec 22, 2023 · 2 comments
Assignees
@Zeitsperre @RondeauG
Labels
bug Something isn't working

Comments

@sebastienlanglois
Copy link
Contributor

sebastienlanglois commented Dec 22, 2023 •
edited
Loading

Setup Information

  • xhydro version: 0.3.0
  • Python version: 3.9 to 3.11
  • Operating System: Ubuntu

Description

Pydantic have just made a new release today (2023-12-22) and since then, we are getting errors coming from xscen :
image

Steps To Reproduce

Installing xscen or xhydro in a new environment with pydantic's newest release (v2.5.3).

Additional context

@Zeitsperre
@RondeauG

Contribution

  • I would be willing/able to open a Pull Request to address this bug.
@sebastienlanglois sebastienlanglois added the bug Something isn't working label Dec 22, 2023
@Zeitsperre
Copy link
Collaborator

Temporary fixes have been proposed in #61 and #62.

@sebastienlanglois sebastienlanglois mentioned this issue Dec 22, 2023
Merged
@sebastienlanglois
Copy link
Contributor Author

I'm closing for now as we have a temporary fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zeitsperre Zeitsperre

@RondeauG RondeauG

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zeitsperre @RondeauG @sebastienlanglois