Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GitHub docs, Add deployment safeguards #28

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Disable GitHub docs, Add deployment safeguards #28

merged 4 commits into from
Sep 8, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 8, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Disables the GitHub Pages documentation (moved to a deactivated folder for reference)
  • Bumpversion will no longer trigger when updating Zenodo and ReadTheDocs
  • As a security measure, PyPI and TestPyPI actions now require the go-ahead from either @TC-FF, @RondeauG, @sebastienlanglois, or @Zeitsperre in order to run.

Does this PR introduce a breaking change?

No.

Other information:

https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

@Zeitsperre Zeitsperre added the documentation Improvements or additions to documentation label Sep 8, 2023
@Zeitsperre Zeitsperre requested a review from RondeauG September 8, 2023 19:41
@Zeitsperre Zeitsperre self-assigned this Sep 8, 2023
@Zeitsperre Zeitsperre changed the title Disable GitHub docs Disable GitHub docs, Add deployment safeguards Sep 8, 2023
@Zeitsperre Zeitsperre merged commit e7cdd8e into main Sep 8, 2023
4 checks passed
@Zeitsperre Zeitsperre deleted the disable-github-docs branch September 8, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @RondeauG