Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for velocity proxy #645

Open
andrewgazelka opened this issue Dec 4, 2024 · 8 comments
Open

add documentation for velocity proxy #645

andrewgazelka opened this issue Dec 4, 2024 · 8 comments
Assignees
Labels
good first issue 🌱 Good for newcomers help wanted 🫂 Extra attention is needed

Comments

@andrewgazelka
Copy link
Collaborator

andrewgazelka commented Dec 4, 2024

  • add docs (presumably to README and/or website)
  • potentially fix bug with it too apparently it might not work? 🤷
Copy link

linear bot commented Dec 4, 2024

@andrewgazelka andrewgazelka changed the title add documentation on using w/ Velocity add velocity support Dec 6, 2024
@andrewgazelka andrewgazelka changed the title add velocity support add velocity proxy support Dec 6, 2024
@andrewgazelka andrewgazelka added help wanted 🫂 Extra attention is needed good first issue 🌱 Good for newcomers labels Dec 7, 2024
@Kumpelinus
Copy link
Collaborator

TODO: Add actual docs.

But in essence the way you will have to set up your velocity is to not forward any player information (it must behave like vanilla. Not like bungeecord default or velocity modern). Hyperion is offline only as well afaik. Might want to add support for those handshakes in the future.

@andrewgazelka
Copy link
Collaborator Author

TODO: Add actual docs.

But in essence the way you will have to set up your velocity is to not forward any player information (it must behave like vanilla. Not like bungeecord default or velocity modern). Hyperion is offline only as well afaik. Might want to add support for those handshakes in the future.

definitely had it online thur velocity at one point but changed a bit

@Kumpelinus
Copy link
Collaborator

Velocity can be in online mode. But the forwarding data that velocity would usually send is leading to crashes. And velocity already handles the user authentication anyways.

@andrewgazelka
Copy link
Collaborator Author

andrewgazelka commented Dec 11, 2024

Velocity can be in online mode. But the forwarding data that velocity would usually send is leading to crashes. And velocity already handles the user authentication anyways.

yea ok we are on same page... yea short term all making this online would be by using a proxy (say velocity)

what is th ebenefit of using the default velocity forwarding method aside from it working out of the box?

@Kumpelinus
Copy link
Collaborator

It is pretty easy to implement and has the added benefit of being able to get a players actual ips and a few other things. You can also set it up so that you require a key from the proxy (thus making sure no one can just bypass the firewall and impersonate others). Valence already has this implemented so it is not that complicated to do. Still not the highest priority

@andrewgazelka
Copy link
Collaborator Author

It is pretty easy to implement and has the added benefit of being able to get a players actual ips and a few other things. You can also set it up so that you require a key from the proxy (thus making sure no one can just bypass the firewall and impersonate others). Valence already has this implemented so it is not that complicated to do. Still not the highest priority

meh ok... hm.. well feel free to impl actually. think it will be useful for testing & new contributors

@Kumpelinus
Copy link
Collaborator

Still splitting the Issue to make it more clear that you can actually run it already and prioritize it differently.

@Kumpelinus Kumpelinus changed the title add velocity proxy support add documentation for velocity proxy Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🌱 Good for newcomers help wanted 🫂 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants