Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlane Warp Deploy not creating file with correct symbol #5164

Open
Xaroz opened this issue Jan 13, 2025 · 0 comments
Open

Hyperlane Warp Deploy not creating file with correct symbol #5164

Xaroz opened this issue Jan 13, 2025 · 0 comments
Assignees

Comments

@Xaroz
Copy link
Contributor

Xaroz commented Jan 13, 2025

Problem

Is your feature request related to a problem? Please describe.
When running hyperlane warp deploy where the resulting synthetic token symbol is different from the collateral one, it will spit out a .config-yaml file that does not contain the correct symbol, but the resulting token is still correct

Additional context

Issue happened when trying to do hyperlane warp deploy from base USDC to artela USDC.a:

export const getArtelaBaseUSDCWarpConfig = async (
  routerConfig: ChainMap<RouterConfigWithoutOwner>,
): Promise<ChainMap<HypTokenRouterConfig>> => {
  const artela: HypTokenRouterConfig = {
    ...routerConfig.artela,
    owner: artelaOwner,
    type: TokenType.synthetic,
    symbol: 'USDC.a',
    interchainSecurityModule: ISM_CONFIG,
  };

  const base: HypTokenRouterConfig = {
    ...routerConfig.base,
    owner: baseOwner,
    type: TokenType.collateral,
    token: tokens.base.USDC,
    interchainSecurityModule: ISM_CONFIG,
  };

  return {
    artela,
    base,
  };
};

After running the command it spits the following config.yaml file:

tokens:
  - addressOrDenom: "0x8d9Bd7E9ec3cd799a659EE650DfF6C799309fA91"
    chainName: artela
    connections:
      - token: ethereum|base|0x01348F639D6e418A5a9673c08c0dDf6ecCB80F37
    decimals: 6
    name: USD Coin
    standard: EvmHypSynthetic
    symbol: USDC
  - addressOrDenom: "0x01348F639D6e418A5a9673c08c0dDf6ecCB80F37"
    chainName: base
    collateralAddressOrDenom: "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913"
    connections:
      - token: ethereum|artela|0x8d9Bd7E9ec3cd799a659EE650DfF6C799309fA91
    decimals: 6
    name: USD Coin
    standard: EvmHypCollateral
    symbol: USDC

But if you check the contract itself, it will show that deploy was done correctly in the correct symbol: https://artscan.artela.network/token/0x8d9Bd7E9ec3cd799a659EE650DfF6C799309fA91

Solution

Describe the solution you'd like
The hyperlane warp deploy command should spit a config file with the correct symbols

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Nice to Have

Describe non-essential extensions to the solution
Additional features which should be implemented if they are easy to accommodate but otherwise can be skipped

@Xaroz Xaroz self-assigned this Jan 16, 2025
github-merge-queue bot pushed a commit to hyperlane-xyz/hyperlane-registry that referenced this issue Jan 17, 2025
### Description

<!--
Summary of change.
Example: Add sepolia chain
-->

This PR along with a PR to the monorepo aims to fix the artifacts for
warp route deployments by taking into account the symbol field,
mentioned in [this
issue](hyperlane-xyz/hyperlane-monorepo#5164)

- Add `WarpRouteOptions` as optional parameter to `addWarpRoute`
- Change `getWarpRouteArtifactPaths` to receive a `symbol` as the folder
path
- Include unit test 
### Backward compatibility

<!--
Are these changes backward compatible? Note that additions are backwards
compatible.

Yes/No
-->

Yes

### Testing

<!--
Have any new metadata configs and deployment addresses been used with
any Hyperlane tooling, such as the CLI?
-->
CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant