You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When running hyperlane warp deploy where the resulting synthetic token symbol is different from the collateral one, it will spit out a .config-yaml file that does not contain the correct symbol, but the resulting token is still correct
Additional context
Issue happened when trying to do hyperlane warp deploy from base USDC to artela USDC.a:
Describe the solution you'd like
The hyperlane warp deploy command should spit a config file with the correct symbols
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Nice to Have
Describe non-essential extensions to the solution
Additional features which should be implemented if they are easy to accommodate but otherwise can be skipped
The text was updated successfully, but these errors were encountered:
### Description
<!--
Summary of change.
Example: Add sepolia chain
-->
This PR along with a PR to the monorepo aims to fix the artifacts for
warp route deployments by taking into account the symbol field,
mentioned in [this
issue](hyperlane-xyz/hyperlane-monorepo#5164)
- Add `WarpRouteOptions` as optional parameter to `addWarpRoute`
- Change `getWarpRouteArtifactPaths` to receive a `symbol` as the folder
path
- Include unit test
### Backward compatibility
<!--
Are these changes backward compatible? Note that additions are backwards
compatible.
Yes/No
-->
Yes
### Testing
<!--
Have any new metadata configs and deployment addresses been used with
any Hyperlane tooling, such as the CLI?
-->
CLI
Problem
Is your feature request related to a problem? Please describe.
When running
hyperlane warp deploy
where the resulting synthetic token symbol is different from the collateral one, it will spit out a.config-yaml
file that does not contain the correct symbol, but the resulting token is still correctAdditional context
Issue happened when trying to do
hyperlane warp deploy
frombase USDC
toartela USDC.a
:After running the command it spits the following config.yaml file:
But if you check the contract itself, it will show that deploy was done correctly in the correct symbol: https://artscan.artela.network/token/0x8d9Bd7E9ec3cd799a659EE650DfF6C799309fA91
Solution
Describe the solution you'd like
The
hyperlane warp deploy
command should spit a config file with the correct symbolsDescribe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Nice to Have
Describe non-essential extensions to the solution
Additional features which should be implemented if they are easy to accommodate but otherwise can be skipped
The text was updated successfully, but these errors were encountered: