refactor: finish removing unwraps #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tkporter
approved these changes
Nov 1, 2023
| // use bech32::Error; | ||
| use hyperlane_core::ChainCommunicationError; | ||
|
|
||
| /// Errors from the crates specific to the hyperlane-cosmos |
| @@ -0,0 +1,22 @@ | |||
| // use bech32::Error; | |||
rust/hyperlane-core/src/error.rs
Outdated
| @@ -6,6 +6,7 @@ use std::ops::Deref; | |||
| use crate::config::StrOrIntParseError; | |||
| use cosmrs::proto::prost; | |||
| use cosmrs::Error as CosmrsError; | |||
| // use fixed_hash::rustc_hex::FromHexError; | |||
daniel-savu
merged commit 355c4a8
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
yorhodes
pushed a commit
that referenced
this pull request
Nov 2, 2023
### Description - Removes unwraps and expects from everywhere but `run-locally` - Precomputes the `address` in `Signer` at construction time, to propagate the error early and keep signatures ergonomic by not requiring a `Result`. Couldn't also precompile `SigningKey` (the privkey type) because it's not `Sync` 😢 - Defines a `hyperlane-cosmos`-specific error enum (`HyperlaneCosmosError`), which can be converted to `ChainCommunicationError` with the `?` operator. This is a pattern we'd like to refactor towards in the future, to remove dependencies from `hyperlane-core` as much as possible - One inconvenience is that you need to `.map_err()` to `HyperlaneCosmosError` first, to use `?`. I wish `?` had deref coercion semantics where it'd keep covnerting until an error matches, but I assume this isn't possible because while you can only have a single `Deref` impl, you can have multiple `From<Err>` impls. - Writing this I'm realising we could write a small macro to implement `From<Err> for ChainCommunicationError` for all the sub-errors of `HyperlaneCosmosError` et al (cc @tkporter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
run-locallyaddressinSignerat construction time, to propagate the error early and keep signatures ergonomic by not requiring aResult. Couldn't also precompileSigningKey(the privkey type) because it's notSync😢hyperlane-cosmos-specific error enum (HyperlaneCosmosError), which can be converted toChainCommunicationErrorwith the?operator. This is a pattern we'd like to refactor towards in the future, to remove dependencies fromhyperlane-coreas much as possible.map_err()toHyperlaneCosmosErrorfirst, to use?. I wish?had deref coercion semantics where it'd keep covnerting until an error matches, but I assume this isn't possible because while you can only have a singleDerefimpl, you can have multipleFrom<Err>impls.From<Err> for ChainCommunicationErrorfor all the sub-errors ofHyperlaneCosmosErroret al (cc @tkporter)