-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor indexing #2889
Merged
tkporter
merged 17 commits into
trevor/new-featv3-cosmos-oct-28
from
trevor/cosmos-indexing-refactor-nov-3
Nov 3, 2023
Merged
Refactor indexing #2889
tkporter
merged 17 commits into
trevor/new-featv3-cosmos-oct-28
from
trevor/cosmos-indexing-refactor-nov-3
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
approved these changes
Nov 3, 2023
tkporter
merged commit Nov 3, 2023
453734a
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
&mut self
, so will have to think about what to do here)unwrap_or_none_result
to not include thelet Some(varname)
bit so we can dolet varname = unwrap_or_none_result!(...)
get_parser(&self, ...)
fn that returns a closure, we just pass a the functionSelf::[data_type]_parser
_contract_address
param (which is auto-set by the cosmwasm runtime). It returns aParsedEvent<T>
so that we can return the_contract_address
in there tooDrive-by changes
n/a
Related issues
n/a
Backward compatibility
Fully
Testing
Unit tests, ran locally