Optional cosmos signer #2890
Merged
Optional cosmos signer #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkporter
approved these changes
Nov 3, 2023
| @@ -289,8 +292,9 @@ impl WasmProvider for WasmGrpcProvider { | |||
| where | |||
| T: Serialize + Send + Sync, | |||
| { | |||
| let signer = self.get_signer()?; | |||
There was a problem hiding this comment.
Flagging that between this & how wasm_simulate -> simulate_raw_tx -> generate_raw_tx which also requires the signer, in practice a signer is still required. I think it's fine to not address this in this PR and for us to just refactor grpc.rs a bunch so that simulating calls doesn't require a signer anymore, but wanted to call out
daniel-savu
force-pushed
the
dan/optional-signer
branch
from
d0036dc to
00f3b0c
Compare
daniel-savu
merged commit 2622389
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes cosmos signer unwraps by making the signer optional. Depends on #2887