Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry program deployments in SVM tooling with higher fees #4904

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Nov 27, 2024

Description

  • A common failure case on Solana has been having trouble getting program deployment txs to land. Parts of the program bytecode are written to a buffer in hundreds of different txs, and some of these fail. Now we will:
    • specify a buffer account
    • automatically retry with the same buffer account (building upon any successful writes to it) and with a higher compute unit price

What will probably follow at some point:

  • programmatically decide what fees to start using

Drive-by changes

  • Always use existing keys if they are present, removing some code complexity here

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 720d269

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (f9396fc) to head (720d269).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4904   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@tkporter tkporter changed the title wip: some SVM tooling improvements feat: retry program deployments in SVM tooling with higher fees Nov 27, 2024
@tkporter tkporter marked this pull request as ready for review November 27, 2024 14:13
Copy link
Contributor

@daniel-savu daniel-savu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 this will also result in much fewer program close commands needing to be run to get back the rent balance and keep retrying

rust/sealevel/client/src/cmd_utils.rs Outdated Show resolved Hide resolved
rust/sealevel/client/src/cmd_utils.rs Show resolved Hide resolved
@tkporter tkporter enabled auto-merge December 12, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants