Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix terminology: batch -> transaction #2293

Closed
wants to merge 1 commit into from

Conversation

LiyanJin
Copy link
Contributor

@LiyanJin LiyanJin commented Mar 9, 2020

No description provided.

@annechenette
Copy link
Contributor

LianJin, thank you for this correction! However, the commit needs a DCO sign-off. You can use these instructions to add a sign-off to the commit:
https://github.com/hyperledger/sawtooth-core/pull/2293/checks?check_run_id=495368110

@dcmiddle
Copy link
Contributor

dcmiddle commented Mar 9, 2020

Thanks @chenette
@LiyanJin you may also need to set your name and email in your git client so that the sign off flag picks up the right values.
https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

@LiyanJin
Copy link
Contributor Author

Thanks for your suggestions. @dcmiddle @chenette
This is my first pull request and I have set my name and email address. However, I'm not familiar with the DCO sign-off. I have tried to add sign-off with reference to the instructions given by you. But it doesn't work. Because I pushed the commit directly on the webpage, instead of pushing it up in my local cloned repository via Git. So the instruction doesn't work for me. Is there any other way to sign-off?

@arsulegai
Copy link
Contributor

@LiyanJin Good approach would be to clone and push with the DCO sign. You may also try this suggestion todogroup/gh-issues#50 (comment)

@LiyanJin
Copy link
Contributor Author

Thanks for your suggestion @arsulegai Let me try it and hope it works for me.

@LiyanJin LiyanJin closed this Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants