-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose/propagate PoolTimeout errors from indy-vdr #973
Comments
Yeah that sounds fair That being said, I want to note that In Absa we have rust script to built up latest genesis files & tool to check for misbehaving nodes (and you can then tell indy-vdr to exclude them) - these can help getting |
issue still present, but should be more easy to solve. mapping to unknown occurs here: https://github.com/hyperledger/aries-vcx/blob/main/aries/aries_vcx_ledger/src/errors/mapping_indyvdr.rs#L21 |
It would be nice if
aries_vcx_core/src/errors/mapping_indyvdr.rs
propagated more error information. Currently, most indy-vdr errors are being mapped intoUnknown
vcx core errors, so we lose information. there is a TODO in this file which notes this, however I'm creating a github issue for it as a reminder.I came across this when attempting to wrap the
IndyVdrLedgeRead
impl with some additional "retry X times on pool timeout errors" logic, since i was encountering some flakey ledger issues that a simple retry would fix.But there is no ideal way of identifying a pool timeout error, since error details are hidden behind
UnknownError
. IMO we should at least propagate pool timeout errors as a new vcx-core error type.The text was updated successfully, but these errors were encountered: