Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF 44 support? #1

Open
nerijus opened this issue Feb 12, 2016 · 12 comments
Open

FF 44 support? #1

nerijus opened this issue Feb 12, 2016 · 12 comments

Comments

@nerijus
Copy link

nerijus commented Feb 12, 2016

I recompiled firefox-44.0.1 with firefox.patch, except that 2nd chunk of the 1st file in the patch (dom/media/eme/EMEUtils.cpp) did not apply. But I cannot play test video from https://shaka-player-demo.appspot.com/. Tried both with and without LD_PRELOAD. I put libwidevine.so and widevine.info to /a/firefox/gmp-widevine/1 and launched FF with command:
MOZ_GMP_PATH=/a/firefox/gmp-widevine/1 firefox

@nerijus
Copy link
Author

nerijus commented Feb 12, 2016

In /proc/26162/map_files (26162 is FF pid) there are links to /usr/lib64/chromium/libwidevinecdm.so when I use LD_PRELOAD, but there is no libwidevine.so, so I assume it is not used?

@i-rinat
Copy link
Owner

i-rinat commented Feb 12, 2016

Are "ClearKey"-labeled videos working on https://shaka-player-demo.appspot.com/ in Firefox-44.0.1? Since Firefox goes through stabilization process, that version could have no required Javascript-side APIs ready.

@nerijus
Copy link
Author

nerijus commented Feb 12, 2016

No, ClearKey is not working.

@i-rinat
Copy link
Owner

i-rinat commented Feb 12, 2016

Then you need a newer version.

Try snapshot from https://hg.mozilla.org/mozilla-central/file/29258f59e545. You can download archive by clicking on either "bz2" or "gz" links.

@nerijus
Copy link
Author

nerijus commented Feb 12, 2016

I recompiled FF 45.0b4, firefox.patch applied without modifications, and https://shaka-player-demo.appspot.com/ and Netflix works. Thanks a lot!

@i-rinat
Copy link
Owner

i-rinat commented Feb 12, 2016

Sounds good.

@nerijus
Copy link
Author

nerijus commented Feb 12, 2016

Will firefox.patch be sent upstream?

@i-rinat
Copy link
Owner

i-rinat commented Feb 13, 2016

Will firefox.patch be sent upstream?

I thought about that, but there are number of reasons against:

  1. Patch is a dirty, I-don't-care-just-make-it-work type. It's not ready for inclusion, but requires additional coding effort from Mozilla;
  2. As the patch have explicit mentions "com.widevine.alpha", it can cause legal issues, which I don't want to impose;
  3. There are already couple of (unrelated to this project) bugreports with ready-to-apply patches, half a year and a year old. But I still have no answers to them, not even a "wontfix". (Those are not of much importance, so I can understand why they are not receiving attention — there are more urgent bugs.) This patch will probably be another abandoned bugreport.

So I don't see any green light on that path.

If however, anybody wants to push it, I have no objections. If there are any license issues, please tell me. I'll make required changes.

@nerijus
Copy link
Author

nerijus commented Feb 14, 2016

@i-rinat
Copy link
Owner

i-rinat commented Feb 14, 2016

ok

@i-rinat
Copy link
Owner

i-rinat commented Apr 9, 2016

Looks like Mozilla is going to add Widevine support: https://blog.mozilla.org/futurereleases/2016/04/08/mozilla-to-test-widevine-cdm-in-firefox-nightly/

@sarge
Copy link

sarge commented Apr 13, 2016

Nice work @i-rinat in their changeset they have credited your work. Thanks @nerijus for taking the initiative to make Firefox aware of this good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants