Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotrim #10575

Open
Mclags opened this issue Jan 5, 2025 · 8 comments
Open

Autotrim #10575

Mclags opened this issue Jan 5, 2025 · 8 comments

Comments

@Mclags
Copy link

Mclags commented Jan 5, 2025

Small change suggested.
Disable continuous auto trim for auto launch mode.

I did something a little dumb that found this little snag. With continuous auto trim enabled, I had my craft sitting on the ground not level. I enabled launch mode but did not arm it. With a nav mode selected it appears that inav trimmed in an attempt to correct the roll axis. So when I armed and launched I had a severe roll trimmed into the craft that the launch mode did not level from.

Craft was sitting on the ground for approx 5 or 6mins in launch mode but unarmed.

After changing centre points back to 1500 in inav configurator, and launching again it launched perfectly.

@MrD-RC
Copy link
Collaborator

MrD-RC commented Jan 5, 2025

Rather than basing it on autolaunch. Maybe it should check to see if the aircraft is flying before trimming.

@Mclags
Copy link
Author

Mclags commented Jan 5, 2025 via email

@Carticiak
Copy link

Thanks for bringing this up. Same thing happened to me, I had to go back and manually set all my trims again, then send it up. Otherwise it was trying to bail hard to the left.

Maybe it can use GPS data to confirm movement?

@MrD-RC
Copy link
Collaborator

MrD-RC commented Jan 6, 2025

Not all aircraft have a GPS. There is a test within the firmware to estimate the aircraft is flying.

@breadoven
Copy link
Collaborator

This shouldn't happen according to the code. Continuous Servo Autotrim is only active when Armed, it does nothing otherwise. Even if Armed it only trims when the plane is flying level in pitch and roll and also only if there's a valid GPS heading which means the plane needs to be flying with enough speed for the GPS to register a heading. So it's hard to see that the problem here was caused by Autotrim.

@Mclags
Copy link
Author

Mclags commented Jan 7, 2025 via email

@breadoven
Copy link
Collaborator

breadoven commented Jan 7, 2025

I can't replicate it. I had launch mode enabled via switch, Continuous Servo Trim enabled, Poshold mode enabled and the plane was disarmed. There's no servo movement other than the usual Acro induced movement when you move the plane around. If you leave it static with some roll angle the servos don't move and the trims don't change.

You'd need to provide a Diff to see if there's some setting causing this. Which Nav mode was enabled ?

@Mclags
Copy link
Author

Mclags commented Jan 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants