-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotrim #10575
Comments
Rather than basing it on autolaunch. Maybe it should check to see if the aircraft is flying before trimming. |
That would work too.
…-------- Original message --------
From: Darren Lines ***@***.***>
Date: 6/01/25 1:12 am (GMT+12:00)
To: iNavFlight/inav ***@***.***>
Cc: Mclags ***@***.***>, Author ***@***.***>
Subject: Re: [iNavFlight/inav] Autotrim (Issue #10575)
Rather than basing it on autolaunch. Maybe it should check to see if the aircraft is flying before trimming.
—
Reply to this email directly, view it on GitHub<#10575 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUZ5ZJFY7XJHWJD633F5T732JEOQ3AVCNFSM6AAAAABUT7IKESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGYYDINBSGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Thanks for bringing this up. Same thing happened to me, I had to go back and manually set all my trims again, then send it up. Otherwise it was trying to bail hard to the left. Maybe it can use GPS data to confirm movement? |
Not all aircraft have a GPS. There is a test within the firmware to estimate the aircraft is flying. |
This shouldn't happen according to the code. Continuous Servo Autotrim is only active when Armed, it does nothing otherwise. Even if Armed it only trims when the plane is flying level in pitch and roll and also only if there's a valid GPS heading which means the plane needs to be flying with enough speed for the GPS to register a heading. So it's hard to see that the problem here was caused by Autotrim. |
I am able to replicate this.
Plane on ground, in a nav mode, disarmed, push one wing down and hold it, can see the control surfaces slowly moving to counter the roll. Very slowly but they do move further and further from set mid point.
…-------- Original message --------
From: breadoven ***@***.***>
Date: 7/01/25 11:11 am (GMT+12:00)
To: iNavFlight/inav ***@***.***>
Cc: Mclags ***@***.***>, Author ***@***.***>
Subject: Re: [iNavFlight/inav] Autotrim (Issue #10575)
This shouldn't happen according to the code. Continuous Servo Autotrim is only active when Armed, it does nothing otherwise. Even if Armed it only trims when the plane is flying level in pitch and roll and also only if there's a valid GPS heading which means the plane needs to be flying with enough speed for the GPS to register a heading. So it's hard to see that the problem here was caused by Autotrim.
—
Reply to this email directly, view it on GitHub<#10575 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUZ5ZJHSQXHX2INOCSYWIJ32JL5QFAVCNFSM6AAAAABUT7IKESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGAYTKNRZGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I can't replicate it. I had launch mode enabled via switch, Continuous Servo Trim enabled, Poshold mode enabled and the plane was disarmed. There's no servo movement other than the usual Acro induced movement when you move the plane around. If you leave it static with some roll angle the servos don't move and the trims don't change. You'd need to provide a Diff to see if there's some setting causing this. Which Nav mode was enabled ? |
Manual mode
Auto launch enabled
Still disarmed
Trims start moving.
I'll post my diff tomorrow afternoon.
…-------- Original message --------
From: breadoven ***@***.***>
Date: 8/01/25 1:00 am (GMT+12:00)
To: iNavFlight/inav ***@***.***>
Cc: Mclags ***@***.***>, Author ***@***.***>
Subject: Re: [iNavFlight/inav] Autotrim (Issue #10575)
I can't replicate it. I had launch mode enabled via switch, Continuous Servo Trim enabled, Poshold mode enabled and the plane was disarmed. There's no servo movement and the trims don't change.
You'd need to provide a Diff to see if there's some setting causing this. Which Nav mode was enabled ?
—
Reply to this email directly, view it on GitHub<#10575 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUZ5ZJFVKU4W5QD7FUKHDT32JO6XHAVCNFSM6AAAAABUT7IKESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGEYTAMZUG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Small change suggested.
Disable continuous auto trim for auto launch mode.
I did something a little dumb that found this little snag. With continuous auto trim enabled, I had my craft sitting on the ground not level. I enabled launch mode but did not arm it. With a nav mode selected it appears that inav trimmed in an attempt to correct the roll axis. So when I armed and launched I had a severe roll trimmed into the craft that the launch mode did not level from.
Craft was sitting on the ground for approx 5 or 6mins in launch mode but unarmed.
After changing centre points back to 1500 in inav configurator, and launching again it launched perfectly.
The text was updated successfully, but these errors were encountered: