Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing transformer to run with no changesets #170

Open
nick4598 opened this issue Apr 22, 2024 · 0 comments
Open

Consider allowing transformer to run with no changesets #170

nick4598 opened this issue Apr 22, 2024 · 0 comments

Comments

@nick4598
Copy link
Collaborator

nick4598 commented Apr 22, 2024

One such example where this might be useful is a filter transform. A user may wish to change the filter criteria, in which the transformer needs to be rerun to process this new filter.

Currently services team expects to always process changesets in addition to changing the filter criteria, but it may be realistic to change the filter criteria and have no changesets to process. There are currently places where transformer exits early if there are no changesets.

One such place is if transformer._sourceDbChanges is undefined (which it currently is if there are no changesets). This would have to be changed.
if (csFileProps === undefined) return undefined;

needs more thought / investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant