Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC query problems #661

Closed
1 of 2 tasks
ugurdogrusoz opened this issue Apr 16, 2021 · 4 comments
Closed
1 of 2 tasks

PC query problems #661

ugurdogrusoz opened this issue Apr 16, 2021 · 4 comments
Assignees

Comments

@ugurdogrusoz
Copy link
Contributor

ugurdogrusoz commented Apr 16, 2021

  • 1. If you perform a PC neighborhood query with HMGS2, you get "Invalid query"? There is nothing invalid about this query. Do we perhaps get no results and interpret that as invalid?
  • 2. If you perform a neighborhood query with PMVK, it takes a while to get the result but the result is not properly laid out:

Screen Shot 2021-04-16 at 11 54 13

According to @hasanbalci this is since we perform "draft" quality layout when results are big.
@ugurdogrusoz ugurdogrusoz changed the title Invalid query PC query problems Apr 16, 2021
@msalihaltun
Copy link
Contributor

msalihaltun commented Jun 1, 2021

The first point is caused by empty response body, we check for data.response.body truth value and empty strings are evaluated as false. How should we fix this? Should we go ahead as normal (i.e load nothing as expected without "invalid query" prompt) or prompt the user that an empty response was received?

@msalihaltun
Copy link
Contributor

msalihaltun commented Jun 1, 2021

On the second point, @hasanbalci is right that we have a check in sbgnviz.js where if number of nodes or edges being loaded exceeds 3000 we use layout quality preference draft. I don't specifically know how this affects the resulting layout.

@ugurdogrusoz
Copy link
Contributor Author

Let's properly notify the user that the response is empty rather than saying their query is invalid. Do not worry about the layout issue.

@msalihaltun
Copy link
Contributor

The failing test is related to #658 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants