Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is failing, jruby this time #117

Open
kytrinyx opened this issue Jan 22, 2017 · 2 comments
Open

CI is failing, jruby this time #117

kytrinyx opened this issue Jan 22, 2017 · 2 comments

Comments

@kytrinyx
Copy link
Collaborator

I'm tempted to stick jruby on the "allowed failures" list. I suspect that if you're writing an etsy app, you're not deploying it on rubinius or jruby. It might be OK to deprecate support for these.
@mattrayner
Copy link
Collaborator

Looking at the error we're getting to do with JSON, and the future Faraday roadmap, ruby as an 'allowed failure' seems okay.

As part of the future work we are doing we can re-address the rubinius and jruby compatibility issues?

@kytrinyx
Copy link
Collaborator Author

As part of the future work we are doing we can re-address the rubinius and jruby compatibility issues?

Yeah, that sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kytrinyx @mattrayner