Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input event is not fired when deleting text or typing numbers in <Editable> component #5669

Open
kiryl-ivanou opened this issue Jun 26, 2024 · 1 comment

Comments

@kiryl-ivanou
Copy link

Description
I've faced the following issue:
When watching input event on Editable component the following happens:

  • When I am just typing text in English, event fires
  • When I am deleting text - does not fire
  • When I am typing numbers - does not fire
  • When I am typing in other language - does not fire

Important notice:

Platforms:
- Android: works as expected in all cases

  • Desktop Chrome - issue as described
  • iOS both Chrome and Safari - issue as described

Recording
Here is Android Chrome recording, there everything works as expected

Android_Chrome.mp4

Here is Desktop Chrome recording, does not work as expected:

desktop-chrome.mp4

Here is iOS Safari recording, does not work as expected:

iOS_Safari.1.mp4

Sandbox
Here is the code sandbox with the reproduce:
https://codesandbox.io/p/devbox/8yj9ww?file=%2Fpackage.json%3A18%2C30

Steps
To reproduce the behavior:

  1. Go to sandbox
  2. Start typing on Slate ContentEditable input on the Desktop or iOS
  3. See that no history is recorder when typing numbers, symbols or deleting text

Expectation
I expect input event to be fired consistently on all platforms as described here: https://developer.mozilla.org/en-US/docs/Web/API/Element/input_event

Environment

  • Slate Version:
    "slate": "^0.103.0",
    "slate-react": "^0.106.0",
    -Platforms:
    - Android: works as expected in all cases
  • Desktop Chrome - issue as described
  • iOS both Chrome and Safari - issue as described

Context
No additional context for now

@dylans
Copy link
Collaborator

dylans commented Jun 27, 2024

This is very surprising. Could you please check 0.105.x for slate-react and see if it’s a regression (I’m at an airport and can’t do much at the moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants