Updating README

ianwalter · Jul 10, 2020 · e4af37c · e4af37c
1 parent 9512701
commit e4af37c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -22,8 +22,5 @@ RUN  apt-get update \
      && rm -rf /var/lib/apt/lists/*
 
 # When installing Puppeteer through npm, instruct it to not download Chromium.
-# Puppeteer will need to be launched with:
-#   browser.launch({ executablePath: 'google-chrome-stable' })
-# This is done by default in @ianwalter/bff.
 ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
 ENV PUPPETEER_EXECUTABLE_PATH google-chrome-stable
diff --git a/README.md b/README.md
@@ -11,9 +11,13 @@ Forked from [buildkite/puppeteer][buildkiteUrl] and based on
 Puppeteer will need to be launched with:
 
 ```js
-browser.launch({ executablePath: 'google-chrome-stable', args: ["--no-sandbox"]})
+browser.launch({ args: ['--no-sandbox'] })
 ```
 
+You may also have to configure `executablePath` to `'google-chrome-stable'` if
+the `PUPPETEER_EXECUTABLE_PATH` environment variable is not correct for some
+reason.
+
 This is done by default in [@ianwalter/bff-puppeteer][bffPuppeteerUrl].
 
 As a [GitHub Action][actionsUrl]:

diff --git a/current.Dockerfile b/current.Dockerfile
@@ -13,8 +13,5 @@ RUN  apt-get update \
      && rm -rf /var/lib/apt/lists/*
 
 # When installing Puppeteer through npm, instruct it to not download Chromium.
-# Puppeteer will need to be launched with:
-#   browser.launch({ executablePath: 'google-chrome-stable' })
-# This is done by default in @ianwalter/bff.
 ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
 ENV PUPPETEER_EXECUTABLE_PATH google-chrome-stable