Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn_outbound_email - missing input field to select attachments #64

Open
gbernat opened this issue Feb 4, 2021 · 0 comments
Open

fn_outbound_email - missing input field to select attachments #64

gbernat opened this issue Feb 4, 2021 · 0 comments

Comments

@gbernat
Copy link

gbernat commented Feb 4, 2021

Description

In version 1.0.0 release notes mention the added capability to select which incident attachments to include in the mail, however that input field is not show once the app is installed.

In the code it looks like everything is ready:
components/send_mail.py:
l.91 -> mail_attachments = kwargs.get("mail_attachments") #text
(Get the function parameters)

The allowed options are evaluated in:
l.187 -> def process_attachments(self, inc_id, attachments):
(*: all, a list, or None)

Probably it only needs to run a new codegen --reload, to get an updated package.

In addition, maybe the reference to the class FunctionComponent in lines l.192 and l.196 is missing:
Instead of:
temp_attach(self, inc_id, incident_attachment_list, attachments, file_list)

Put:
FunctionComponent.temp_attach(self, inc_id, incident_attachment_list, attachments, file_list)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant