Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Openj9PropsExt.java to set necessary Properties for @requeries expressions #245

Open
sophia-guo opened this issue Nov 3, 2020 · 1 comment
Open

Update Openj9PropsExt.java to set necessary Properties for @requeries expressions #245

sophia-guo opened this issue Nov 3, 2020 · 1 comment

Comments

@sophia-guo
Copy link
Contributor

Openj9PropsExt.java need to be updated to support setting Properties required by @requires expressions.

For example Property vm.bits, otherwise tests with @requires property will be skipped.

eclipse-openj9/openj9#11048
@sophia-guo sophia-guo mentioned this issue Nov 5, 2020
Merged
@sophia-guo
Copy link
Contributor Author

sophia-guo commented Nov 5, 2020 •
edited
Loading

vm.bits is set in #246 to solve eclipse-openj9/openj9#11048.

There are still some other properties need to be set, which are mainly used in hotspot component. When enabled tests with those properties requirements will be added back to run and there could be failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophia-guo