Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share classes specific patch doesn't have comment // xxx-shared_classes_misc #256

Open
JasonFengJ9 opened this issue Jan 30, 2019 · 1 comment
Open

Share classes specific patch doesn't have comment // xxx-shared_classes_misc #256

JasonFengJ9 opened this issue Jan 30, 2019 · 1 comment

Comments

@JasonFengJ9
Copy link
Member

Share classes specific code patched to OpenJDK usually have comments such as //IBM-shared_classes_misc which is going to be changed to //OpenJ9-shared_classes_misc as per ibmruntimes/openj9-openjdk-jdk11#113.

Unlike https://github.com/ibmruntimes/openj9-openjdk-jdk, https://github.com/ibmruntimes/openj9-openjdk-jdk12, and https://github.com/ibmruntimes/openj9-openjdk-jdk11, those share classes specific code within this repo doesn't have such comments which makes identifying those share classes code less straightforward.

FYI: @DanHeidinga @pshipton @hangshao0
@hangshao0
Copy link
Contributor

It was patched by this commit:
84153c7#diff-d999e18ac8ce87ae32b06507e9727d04

The shared_classes_misc comments are missing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JasonFengJ9 @hangshao0