Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use get_initial_spectra from snewpy models #96

Open
sybenzvi opened this issue Oct 13, 2023 · 0 comments
Open

use get_initial_spectra from snewpy models #96

sybenzvi opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sybenzvi
Copy link
Collaborator

When ASTERIA accesses spectra from snewpy models, it is pulling out the meanE and pinch attributes of the model classes and then computing energy spectra from those. Instead, it should be using the models' native function call

spectra = model.get_initial_spectra(t, E)

Is there a good reason we are not doing this? As written the code is brittle and doesn't respect the encapsulation provided by the model classes.

@sybenzvi sybenzvi added the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant