Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest integration plan #797

Open
thehrh opened this issue Aug 8, 2024 · 0 comments
Open

pytest integration plan #797

thehrh opened this issue Aug 8, 2024 · 0 comments

Comments

@thehrh
Copy link
Contributor

thehrh commented Aug 8, 2024

I decided to open this issue as a place to document any future discussion about this topic. The PISA guide on general conventions has been stating for a long time that the plan is to integrate pytest, I presume to auto-detect, run, and report on the results of unit tests.

Installing pytest has been part of several workflows since #701, but apparently only because of the existence of two lines in two unit tests (binning.test_MultiDimBinning() and pisa_tests.test_kde_stage) that are relying on pytest.raises() as a context manager.

#580 looks as if it was meant as a custom implementation of some pytest-like functionality, avoiding it as external dependency, but I'm not sure whether this interpretation is correct. The merged branch was even called "pytest".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant