Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: days in future bug (#274) persists #295

Open
2 tasks done
snigehere opened this issue Apr 13, 2024 · 1 comment
Open
2 tasks done

[Bug]: days in future bug (#274) persists #295

snigehere opened this issue Apr 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@snigehere
Copy link

Requirements

  • I checked the troubleshooting section in the README to verify that I have the latest TrashCard version.
  • I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior

the issue described in #274 persists after installing 2.2.1

trash collections for two days in the future show up when filter is set to only show one day in the future.

As described in the prior defect I have two calendars with collections coming from both. Items from one calendar (manually entered full day events) display as expected on the day before the collection date. Items from the second calendar, populated via the waste collection schedule integration, show the correct date in the card but it shows up two day prior to the collection date

Expected Behavior

bin collections scheduled for monday .. reminder should not show up until sunday (its currently saturday)

Steps To Reproduce

set card config

event_grouping: true
drop_todayevents_from: '10:30:00'
next_days: 1
pattern:

  • icon: mdi:flower
    color: brown
    type: organic
    label: Brown Bin
    pattern: garden waste bin
  • icon: mdi:newspaper
    color: blue
    type: paper
  • icon: mdi:recycle-variant
    color: green
    type: recycle
    label: Green Bin
    pattern: recycling bin
  • icon: mdi:trash-can-outline
    color: black
    type: waste
    label: Black bin
    pattern: refuse bin
  • icon: mdi:dump-truck
    color: purple
    type: others
  • label: Food Waste
    icon: mdi:silverware-variant
    color: grey
    type: custom
    pattern: food waste bin
    card_style: chip
    alignment_style: left
    items_per_row: 1
    refresh_rate: 60
    with_label: true
    type: custom:trash-card
    entities:
  • calendar.portsmouth_city_council
  • calendar.home_assistant_calendar
    hide_time_range: false
    icon_size: 30
    use_summary: false

card shows one entry ahead of time

Context

No response

Environment

- Browser: chrome
- HA Version: 
Core 2024.4.3
Supervisor 2024.04.0
Operating System 12.2
Frontend 20240404.2
- TrashCard: 2.2.1

Debug data

see also https://github.com/idaho/hassio-trash-card/issues/274

DEBUG LOG
timezone
"+01:00"
calendar data
[
  {
    "start": {
      "date": "2024-04-15"
    },
    "end": {
      "date": "2024-04-16"
    },
    "summary": "refuse bin",
    "description": null,
    "location": null,
    "uid": null,
    "recurrence_id": null,
    "rrule": null,
    "entity": "calendar.portsmouth_city_council"
  }
]
normaliseEvents
[
  {
    "date": {
      "start": "2024-04-14T23:00:00.000Z",
      "end": "2024-04-15T23:00:00.000Z"
    },
    "isWholeDayEvent": true,
    "content": {
      "summary": "refuse bin",
      "description": null,
      "location": null,
      "uid": null,
      "recurrence_id": null,
      "rrule": null,
      "entity": "calendar.portsmouth_city_council"
    }
  }
]
dropAfter
false
now
"2024-04-13T00:15:53.493Z"
activeElements
[
  {
    "date": {
      "start": "2024-04-14T23:00:00.000Z",
      "end": "2024-04-15T23:00:00.000Z"
    },
    "isWholeDayEvent": true,
    "content": {
      "summary": "refuse bin",
      "description": null,
      "location": null,
      "uid": null,
      "recurrence_id": null,
      "rrule": null,
      "entity": "calendar.portsmouth_city_council"
    }
  }
]
eventsToItems
[
  {
    "date": {
      "start": "2024-04-14T23:00:00.000Z",
      "end": "2024-04-15T23:00:00.000Z"
    },
    "isWholeDayEvent": true,
    "content": {
      "summary": "refuse bin",
      "description": null,
      "location": null,
      "uid": null,
      "recurrence_id": null,
      "rrule": null,
      "entity": "calendar.portsmouth_city_council"
    },
    "icon": "mdi:trash-can-outline",
    "color": "black",
    "type": "waste",
    "label": "Black bin",
    "pattern": "refuse bin",
    "idx": 3
  }
]

Anything else?

I have looked at the calendar entries from the two calendars and don't see any difference however i wonder if the issue is related to timezone in filters? in the uk we are GMT +1 and so the entry shown the the debug shows the 14th at 23:00 GMT/UTC as the start ,, if the timezone is ignored then it will show the as being due tomorrow rather than the 15th......

@snigehere snigehere added the bug Something isn't working label Apr 13, 2024
@snigehere
Copy link
Author

pictures..
calendar view
Snap3

card in ha showing refuse bit
Snap4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant