Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing Error with Tally Segment #377

Closed
MicahGale opened this issue Feb 16, 2024 · 2 comments · Fixed by #409
Closed

Parsing Error with Tally Segment #377

MicahGale opened this issue Feb 16, 2024 · 2 comments · Fixed by #409
Assignees
@MicahGale
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified.

Comments

@MicahGale
Copy link
Collaborator

The error message:

     21139| fs14  -6002
     21140|       -6003
     21141|       -6004
     21142|       -6005
     21143|       -6006
     21144|       -6007
     21145|       -6008
     21146|       -6009
     21147|       -6010
     21148|       -6011
     21149|       -6012
     21150|       -6014
     21151|       -6015
     21152|       -6016
     21153|       -6017
     21154|       -6018
     21155|       -6019
     21156|       -6020
     21157|       -6021
     21158|       -6022
     21159|       -6023
     21160|       -6024 T
The input ended prematurely.
sly: Parse error in input. EOF

I suspect that tally segments just need to use TallyParser
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified. labels Feb 16, 2024
MicahGale added a commit that referenced this issue Jun 13, 2024
@MicahGale
Wrote tally segment test to replicate #377.
ece5de1
@MicahGale MicahGale mentioned this issue Jun 13, 2024
Merged
3 tasks
@MicahGale MicahGale linked a pull request Jun 13, 2024 that will close this issue
Tally segment parsing bug fix. #409
Merged
3 tasks
MicahGale added a commit that referenced this issue Jun 13, 2024
@MicahGale
Updated changelog to include #377
c434138
@MicahGale MicahGale self-assigned this Jun 13, 2024
@tjlaboss
Copy link
Collaborator

In the MCNP6.3 manual, Section 5.9.14:

image

The parser needs to support ending in a C, T, both, or neither

@MicahGale
Copy link
Collaborator Author

I did read the manual... after you mentioned this.

@MicahGale MicahGale mentioned this issue Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tally segment parsing bug fix. idaholab/MontePy
2 participants
@MicahGale @tjlaboss