-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Pull Request Checklist #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Brijeshthummar02 for tackling this.
For some context, I am the main contributor and usually opening most of the PRs myself, and I feel like I have been getting a little bit lazy with this. This issue was mostly a quick note I mostly wrote to myself to update the checklist so I get less lazy with my PRs. So sorry that there was some ambiguity in the issue.
If you would like to make more contributions we have a tag for issues that might be easier to start with: good first issue. Out of curiosity: how did you come across MontePy? It is a bit of a niche library.
@Brijeshthummar02 I wanted to check on this. Are you able to make these changes? If I don't hear back in a week I will close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these changes. This is looking pretty good. I am happy with merging this as is, and making small tweaks later. Let me know if you want to make the changes I suggested or if you want me to merge this as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution @Brijeshthummar02
I'm going to override the doc-build failure. It looks like LANL's website is down for now. If they changed their website again that's a different issue. |
Description
here’s an improved version of your .md checklist file with added sections for documentation standards, details on expected documentation, and coverage reports.
Fixes #591
Checklist