Should Moose check block-restriction in FEProblemBase::duplicateVariableCheck #28560
-
Check these boxes if you have followed the posting rules.
QuestionDear Moose-Community, Many of my Moose models consit of several subdomains / blocks while not all Variables and/or AuxVariables live on all subdomains/blocks. When setting up my models, I have repeatedly had the problem that variables/aux variables are required by different kernels, but were restricted to different blocks (which is of course a mistake on my part and/or other problems e.g. #28308). It would have been good if Moose had pointed out the problem of the inconsistent block restriction of the variables/aux variables more directly: Therefore, should Moose check block-restriction in FEProblemBase::duplicateVariableCheck and warn/error? moose/framework/src/problems/FEProblemBase.C Lines 2843 to 2844 in 1926a67 moose/framework/src/problems/FEProblemBase.C Lines 2540 to 2551 in 1926a67 |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
Hello If you want the message to be more verbose and give more information (such as the block restriction) then that would work for us. Already it says "different type" but it would help the user to say which types are involved However we can't really allow the check to let two "identical" variables be added without some serious checking. There are many variable parameters, we would have to check them all, not just the block restriction. Guillaume |
Beta Was this translation helpful? Give feedback.
Hello
If you want the message to be more verbose and give more information (such as the block restriction) then that would work for us. Already it says "different type" but it would help the user to say which types are involved
However we can't really allow the check to let two "identical" variables be added without some serious checking. There are many variable parameters, we would have to check them all, not just the block restriction.
Guillaume