Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sinttest] Normalization of SpecificationReference to include dash-seperator #593

Merged

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented May 10, 2024

When comparing SINT-configuration to annotations, a bit of normalization occurs, to ensure that common variations in denoting a specification are detected to be equal to each-other.

The dash (-) character is commonly used when referencing a specification (eg: XEP-0001).

This commit ensures that usage of a dash (-) character is included in the normalization process, making XEP 0001, XEP0001 and XEP-0001 all to be identified as the same reference.

@guusdk guusdk force-pushed the sinttest_specref-normalization-dash branch from 682d00b to daf566b Compare May 10, 2024 13:00
…perator

When comparing SINT-configuration to annotations, a bit of normalization occurs, to ensure that common variations in denoting a specification are detected to be equal to each-other.

The dash (`-`) character is commonly used when referencing a specification (eg: `XEP-0001`).

This commit ensures that usage of a dash (`-`) character is included in the normalization process, making `XEP 0001`, `XEP0001` and `XEP-0001` all to be identified as the same reference.
@guusdk guusdk force-pushed the sinttest_specref-normalization-dash branch from daf566b to 121d4ac Compare May 10, 2024 13:05
guusdk added a commit to XMPP-Interop-Testing/smack-sint-server-extensions that referenced this pull request May 10, 2024
When comparing SINT-configuration to annotations, a bit of normalization occurs, to ensure that common variations in denoting a specification are detected to be equal to each-other.

The dash (`-`) character is commonly used when referencing a specification (eg: `XEP-0001`).

This commit ensures that usage of a dash (`-`) character is included in the normalization process, making `XEP 0001`, `XEP0001` and `XEP-0001` all to be identified as the same reference.

This duplicates the effort in Smack: igniterealtime/Smack#593
@guusdk guusdk requested a review from Flowdalic May 10, 2024 13:18
guusdk added a commit to XMPP-Interop-Testing/smack-sint-server-extensions that referenced this pull request May 16, 2024
When comparing SINT-configuration to annotations, a bit of normalization occurs, to ensure that common variations in denoting a specification are detected to be equal to each-other.

The dash (`-`) character is commonly used when referencing a specification (eg: `XEP-0001`).

This commit ensures that usage of a dash (`-`) character is included in the normalization process, making `XEP 0001`, `XEP0001` and `XEP-0001` all to be identified as the same reference.

This duplicates the effort in Smack: igniterealtime/Smack#593
@Flowdalic Flowdalic added this pull request to the merge queue Jun 1, 2024
Merged via the queue into igniterealtime:master with commit 0db1c7a Jun 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants