SMACK-945: MUC Item actor's nick to XML #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flowdalic
requested changes
Jul 7, 2024
If an actor's nick is set in `MUCItem` this value should be added to the XMPP representation of the instance. Fixes SMACK-945
guusdk
force-pushed
the
SMACK-945_Actor-nick-in-XML
branch
from
8ec0d83
to
7c27a70
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an actor's nick is set in
MUCItemthis value should be added to the XMPP representation of the instance.Note that I've not tested this change.
It is worth considering adding more changes to Smack related to this. Where it now exposes
MUCItem#actor,MUCItem#actorNickshould possibly be exposed too.