Automatically close the creature upgrade window when there are not enough resources to perform the operation

[LeHerosInconnu]

I suggest to automatically close the creature upgrade window when there are not enough resources to perform the operation.

In fheroes2:

2022-11-03.13-21-41.mp4

Here is the save file:
Upgrade improvement 01.zip

[zenseii]

Do you mean the same behavior as a right click? Is this how buildings work when you do not have enough resources for them?

[LeHerosInconnu]

Hello @zenseii,

Do you mean the same behavior as a right click? Is this how buildings work when you do not have enough resources for them?

Closing this window:

Automatically closes the creature window:

If by right click you are referring to this: #2607, then yes should work the same way too.

For buildings, only these screens are displayed:

And the Castle construction screen should not be closed.

[ihhub]

Hi @LeHerosInconnu , doing something automatically is very dangerous because many users won't even understand what is going on. Some need time to read a message, other are expecting to come back to the previous creature info dialog and probably dismiss the creature.

[ihhub]

Hi @LeHerosInconnu , could you please explain or show how exactly it is going to be? From what I understood you are asking to automatically close both windows if there are not enough resources. Is it correct?

[LeHerosInconnu]

@ihhub.

Hi @LeHerosInconnu , could you please explain or show how exactly it is going to be? From what I understood you are asking to automatically close both windows if there are not enough resources. Is it correct?

When the user closes this window by pressing the "OKAY" button:

This window is automatically closed at the same time (without the user having to press the "EXIT" button).

[Branikolog]

Hello, @LeHerosInconnu !
I think this can slightly confuse players. While upgrading creatures players tend to press OK button promptly, without even reading the message. So, in a case we close both windows, players could think, that they succeeded in upgrading the creature, which is not the case. Leaving window with non-upgraded creature info would catch players attention, that something went wrong. Also, a player would try to check once again, how much resources did he need, since he can press OK on previous window without even reading, as he thought, he just upgrades the creature. This would lead to unwanted initiating creature window by double click one more time.
Probably not all players are so unobservant, but I'm pretty sure, significant amount players would be confused by such instant closing of both windows. I think we can sacrifice 1 second here (on closing the window manually) to make it 100% clear for players, and focus them, that upgrade was not successful.

[LeHerosInconnu]

Hello @Branikolog,

What about this:
A "happy sound" could be played when the troop has been upgraded, and a "sad sound" could be played when the troop has not been upgraded.

[Branikolog]

Hi, @LeHerosInconnu

What about this: A "happy sound" could be played when the troop has been upgraded, and a "sad sound" could be played when the troop has not been upgraded.

Adding new sound for such action is nice idea, but I'm not sure it suits current game design, where only 1 sound happens on building or hiring a hero. This could be discussed with all our community. Also, a new suitable sound should be created.

But anyway, I'm personally comfortable with the current implementation, where in a case of not succeeded upgrade I watch on the screen the window and focus on a problem after rather mechanical actions of upgrading multiple troops.