Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove variadic generics from Engine typing #8

Closed
iluvcapra opened this issue Jun 20, 2023 · 1 comment
Closed

[BUG] Remove variadic generics from Engine typing #8

iluvcapra opened this issue Jun 20, 2023 · 1 comment
Assignees
@iluvcapra
Labels
bug Something isn't working

Comments

@iluvcapra
Copy link
Owner

iluvcapra commented Jun 20, 2023 •
edited
Loading

Describe the bug
The Engine class uses protobuf enums in its typing, these aren't supported below Python 3.11. See PEP 646.

The Engine class should maybe avoid these type statements or possibly import annotations from __future__ if that would make the code work on earlier versions of Python.
@iluvcapra iluvcapra added the bug Something isn't working label Jun 20, 2023
@iluvcapra iluvcapra self-assigned this Jun 20, 2023
@iluvcapra iluvcapra changed the title [BUG] Remove variadic generics from Engine tying [BUG] Remove variadic generics from Engine typing Jun 20, 2023
@iluvcapra
Copy link
Owner Author

This is fixed by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iluvcapra iluvcapra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iluvcapra