-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearing the search bar still yields script template results #113
Comments
This seems to be a problem with the Script templates |
I agree that we should fix it in the script template searcher. But it would also be good to have explicit handling here in napari-imagej to clear the results explicitly whenever the text field gets blanked out. @gselzer wrote:
#@ PluginService ps
from org.scijava.search import Searcher
for searcher in ps.getPluginsOfType(Searcher):
print(searcher)
|
I don't think it's that simple @ctrueden. Getting from search text to results is all done through event handlers, and we leave any search ordering up to the For example, suppose you start from a fresh terminal, and type As much as I'd like to handle clearing the search bar ourselves, it would take a lot of yucky refactoring to do so |
Once we clean up scijava/scijava-search#30, we should bump the "recommended" (not hard minimum) version of scijava-search, and this will be solved! |
Type a search string, then delete what you typed. There will still be results in the results box, specifically Script templates:
The text was updated successfully, but these errors were encountered: