Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate/Remove one of HyperSphere or HyperSphereNeighborhood #68

Open
hanslovsky opened this issue Jun 25, 2018 · 2 comments
Open

Deprecate/Remove one of HyperSphere or HyperSphereNeighborhood #68

hanslovsky opened this issue Jun 25, 2018 · 2 comments
Labels
enhancement

Comments

@hanslovsky
Copy link
Member

HyperSphere and HyperSphereNeighborhood do the same thing. Having both in imglib2-algorithm is confusing for the caller. I suggest to remove HyperSphere once #67 is fixed because HyperSphereNeighborhood implements Neighborhood as a common interface with other similar classes (HyperSphere is the lone class in its package).
@acardona
Copy link
Contributor

To further add: HyperSphereNeighborhood is missing documentation, in addition to having bug #67. The deprecation of HyperSphere seems premature.

@hanslovsky
Copy link
Member Author

That's why I suggested to remove it

once #67 is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acardona @hanslovsky