Update FloodFill interface #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #55 Current interface is not intuitive: - Deprecate confusing interfaces: - Filter - Writer - TypeWriter - Replace by: - BiPredicate - Consumer - Deprecate current interfaces and add new interfaces using BiPredicate/Consumer Also, use only single storage array for coordinate queue. This has potential benefits (cache locality) but needs benchmarking.
For 4D, data is only about 1/40 of what it used to be.
|
@imglib/admins any objections against a merge? Also, the newly deprecated methods should be considered for #61 |
|
I had a very brief look and it looks good to me. Fine to merge it. Independent of this fix, in the javadoc of generic parameters, I would say what they represent, not the restrictions. * @param <T>
* T implements {@code Type<U>}.just repeats (in this case wrong) what the method signature says anyways. * @param <T>
* input pixel type.
* @param <U>
* fill label type.would be more helpful. |
|
Will update the JavaDoc and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Current interface is not intuitive: