Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasmax at frequency 1hr should be removed from data request urbrcc #12

Open
larsbuntemeyer opened this issue Aug 25, 2024 · 3 comments
Open
Labels
FPS-URB-RCC Issue relevant for FPS-URB-RCC

Comments

@larsbuntemeyer
Copy link
Contributor

larsbuntemeyer commented Aug 25, 2024

In data-request-fpsurbrcc.csv, the daily temperature maxima and minima are requested at hourly frequency which does no make sense. I think it should be removed...

@larsbuntemeyer larsbuntemeyer changed the title tasmax at frequency 1hr should be removed from data request urbcc tasmax at frequency 1hr should be removed from data request urbrcc Aug 25, 2024
@jesusff
Copy link
Member

jesusff commented Aug 26, 2024

Yes, good catch. This was inherited from the FPS Google sheet. I'm not sure if this was just a typo or these were meant to be hourly temperature maxima/minima

@LFEBoberg
Copy link

The same goes for wsgsmax, right?

@jesusff
Copy link
Member

jesusff commented Sep 12, 2024

Thank you, yes. This is exactly the same situation as with tasmax/min. Hourly wsgsmax was in the original data request from the FPS-CONV, but defined without the "Daily" in the long_name. Probably intended as hourly maximum wind gust. The comments in the excel file says:

can be defined as either the maximum wind speed of a time interval or calculated from a gust parameterization; indicate method in "comments"

The "Daily" part comes from the CORDEX-CMIP6 data request, where I took the rows for this CSV version of the FPS-CONV data request.

In summary, for this variable, we should either remove entirely the 1hr request or delete the "Daily" from the long_name

@jesusff jesusff added the FPS-URB-RCC Issue relevant for FPS-URB-RCC label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FPS-URB-RCC Issue relevant for FPS-URB-RCC
Projects
None yet
Development

No branches or pull requests

3 participants