Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore button filters & stack navigation #1271

Closed
25 tasks done
kueda opened this issue Mar 11, 2024 · 3 comments
Closed
25 tasks done

Explore button filters & stack navigation #1271

kueda opened this issue Mar 11, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kueda
Copy link
Member

kueda commented Mar 11, 2024

There are a number of entry-points to Explore, each with different contexts and expectations about what view is presented and what the filters are. Furthermore, most of these buttons push Explore onto an existing stack navigator, e.g. MyObs -> ObsDetails -> TaxonDetails -> Explore, or even more confusingly, Explore -> TaxonDetails -> Explore, and in these stacked contexts, Explore needs a back button to pop it off the stack and return to the previous screen (plus the previous Explores need to keep their state).

  • MyObs toolbar Explore button should
    • Show the Observations view
    • Show a back button that takes you back to MyObs
    • Have an accessibility label that makes it clear you are going to see all of your observations in Explore
    • Filter observations by the current user with no other filters, i.e. user_id=1&verifiable=any and no default geographic filters like nearby
  • TaxonDetails Explore button should
    • Show the Observations view
    • Have an accessibility label that makes it clear you are going to see observations of this taxon in Explore
    • Show a back button that takes you back to TaxonDetails
    • Filter observations by the taxon that are verifiable with no other filters, i.e. taxon_id=1&verifiable=any and no default geographic filters like nearby
  • UserProfile observations button
    • Show the Observations view
    • Show a back button that takes you back to UserProfile
    • Have an accessibility label that makes it clear you are going to see observations by that user in Explore
    • Filter observations by the profile user that are verifiable with no other filters, i.e. user_id=1&verifiable=true and no default geographic filters
  • UserProfile species button
    • Show the Species view
    • Show a back button that takes you back to UserProfile
    • Have an accessibility label that makes it clear you are going to see species observed by that user in Explore
    • Filter observations by the profile user that are verifiable with no other filters, i.e. user_id=1&verifiable=true and no default geographic filters
  • Bottom tabs Explore button should

I would try to experiment with at least two different screens, one for the root Explore accessed from the bottom tabs that should never have a back button, and another for the Explore that can be stacked (with a back button). Ideally every stacked screen is a separate instance and doesn't navigate you back when you do something like Explore -> TaxonDetails -> Explore -> TaxonDetails -> Explore. Alternatively, maybe it would work if the bottom tabs button just resets the nav state.

@kueda kueda added the enhancement New feature or request label Mar 11, 2024
@kueda kueda moved this to Todo in iNat Mobile Mar 11, 2024
@albullington albullington self-assigned this Mar 19, 2024
@albullington
Copy link
Collaborator

@kueda there's one other entry point I see for explore, from the logged out MyObservations screen. should that one operate similar to the bottom tabs entry point -- species view, default to nearby if location permissions are given, and no filters except verifiable? and should it have a back button to return to MyObservationsEmpty?

@kueda
Copy link
Member Author

kueda commented Mar 25, 2024

Let's treat it exactly like the bottom tabs entry point, no back button.

@albullington
Copy link
Collaborator

closed by PR #1306

@github-project-automation github-project-automation bot moved this from Todo to Done in iNat Mobile Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants