Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Distinction between spectating a battle and taking part in a battle. #5

Open
insomniac-eeper opened this issue Jun 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@insomniac-eeper
Copy link
Owner

Is your feature request related to a problem? Please describe.
Spectator battles are not being handle appropriately rather it appears in certain situations a spectator battle is treated as a battle that the protagonist is participating in.

Describe the solution you'd like
Distinguish between spectator battles and protagonist involved battles for BattleRecord and output presence accordingly. For example when spectating: Spectating battle between and .

Describe alternatives you've considered
None

Additional context
None

@insomniac-eeper insomniac-eeper added the enhancement New feature or request label Jun 2, 2024
@insomniac-eeper insomniac-eeper self-assigned this Jun 2, 2024
@insomniac-eeper
Copy link
Owner Author

Note for further context, this happened when setting the protagonist to Bob and initiating a fight. BattleManage2 appears to have a check for protagonist which looks at the CharacterAttributes to determine if either of the two combatants are the protagonist. Otherwise an AI battle will play out and the rich presence will appear as if I am fighting against bob (even though in the scenario I was bob). The determination of who the opponent is in this case should be solely due to who was left or right since my assumption is that protag check failed.

Further investigation into setting the protagonist and where different areas of code check who is protagonist are needed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant