Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform dhcpv4 and dhcpv6 Parse methods #22

Open
insomniacslk opened this issue Mar 26, 2018 · 3 comments
Open

Uniform dhcpv4 and dhcpv6 Parse methods #22

insomniacslk opened this issue Mar 26, 2018 · 3 comments

Comments

@insomniacslk
Copy link
Owner

The dhcpv4 and dhcpv6 packages use two different conventions for option parsing. In dhcpv4 the option is parsed along with option code and length, in dhcpv6 these are handled earlier, and the Parse* methods only handle the data, assuming that the option code is the same as the used option.

Let's uniform the two interfaces for consistency.

@pmazzini
Copy link
Collaborator

Do you have any preference of one over the other?

@insomniacslk
Copy link
Owner Author

I prefer the dhcpv6 convention but happy to discuss

@pmazzini
Copy link
Collaborator

Leaving this open since we now need to simplify the dhcpv6 parsing using github.com/u-root/u-root/pkg/uio to match the improvements recently added to dhcpv4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants