-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Video] Video Component to extract 1 frame every N seconds #1115
Comments
I am interested in this issue @ShihChun-H |
@samir-advantech Awesome! Let me assign this issue to you. Please make sure to read and follow the rules above 🙌🏻 |
Hi @samir-advantech, I'm following up to check on any progress made regarding this issue. Could you please provide an update? Thanks 🙏 |
Hi, @ShihChun-H ! If @samir-advantech is not available or working on this, can I work on this? |
Hey @samir-advantech, since this issue has not been worked on for over >5 days, I will now assign this issue to @Reckadon 🙏 Thank you for your contribution attempt! |
hi @kuroxx, thanks for letting me contribute. |
Hey @Reckadon, thanks for raising the issue! I saw your message on Discord - hope it can be resolved after adjusting the Docker resources : https://www.instill.tech/docs/core/deployment#docker-resource-requirements |
do we want to accept inputs like 10, 30, 1/5, 1/10 only or, are pure numbers fine? like- 10, 30, 0.2, 0.1, 0.5 accepting both numbers and fractional strings will require the |
It seems good that we can support 1/5 or 0.2.
Yes, please proceed this. Thanks for confirmation! |
@chuang8511 but the main issue is can the type field be |
Oh, I did not notice it. |
Setting it as |
opened a PR to close this issue |
@chuang8511 @donch1989 please review when you are free 🙏 thank you! |
…ber, and added some debugging flags for ffmpeg (#765) Because - The Video Component minimum FPS is 1 (integer), For a use case like presentation in the video, we do not want to extract 1 frame every second but 1 frame every 10 seconds to save resources and reduce the number of images needed to feed into the next component. - Issue instill-ai/instill-core/issues/1115. This commit - Change FPS to accept real number inputs as well i.e. 60, 30, 1, 0.5, 0.2, 0.1 in both the tasks `TASK_SUBSAMPLE_VIDEO` and `TASK_SUBSAMPLE_VIDEO_FRAMES`. - Also implements a string parsing function which can handle fractional inputs like 1/2 and 1/5 but is commented out - because the input `type` can only be defined as one single type (`number` or `string` and not both). The function can be used if this issue is resolved in the future.
…ber, and added some debugging flags for ffmpeg (#765) Because - The Video Component minimum FPS is 1 (integer), For a use case like presentation in the video, we do not want to extract 1 frame every second but 1 frame every 10 seconds to save resources and reduce the number of images needed to feed into the next component. - Issue instill-ai/instill-core/issues/1115. This commit - Change FPS to accept real number inputs as well i.e. 60, 30, 1, 0.5, 0.2, 0.1 in both the tasks `TASK_SUBSAMPLE_VIDEO` and `TASK_SUBSAMPLE_VIDEO_FRAMES`. - Also implements a string parsing function which can handle fractional inputs like 1/2 and 1/5 but is commented out - because the input `type` can only be defined as one single type (`number` or `string` and not both). The function can be used if this issue is resolved in the future.
Issue Description
Current State
Why We Want to Change?
Proposed Change
Rules for the Component Hackathon
Component Contribution Guideline | Documentation | Official Go Tutorial
The text was updated successfully, but these errors were encountered: