Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest of ui design was done. swap and gov coming #32

Closed
wants to merge 2 commits into from

Conversation

alextantumpay
Copy link
Contributor

No description provided.

@brenzi
Copy link
Contributor

brenzi commented Jun 4, 2024

QR scanner broken. I'll cherry-pick into another PR to fix

@brenzi
Copy link
Contributor

brenzi commented Jun 4, 2024

@alex-byteport I tried to fix the z-order, but it didn't work.

problem:

  1. tap send
  2. tap scan QR
  3. QR code scanner isn't shown (it is shown "below" send overlay)

I was able to make scanoverlay visible, but when I tap "cancel on the scan overlay, the send overlay closes instead of the scan overlay (this even happens if I remove the cancel button on scanoverlay if I tap the area where the invisible button below on sendoverlay would be.

Something is messed up with z-order. May I ask you to fix this and test the entire flow including scanning and canceling at any point?

@brenzi
Copy link
Contributor

brenzi commented Jun 5, 2024

integrated this into #33 please work on a new branch starting on top of #33 until we fix the z-order issue

@alextantumpay and please run prettier . --write before commits (or as separate commits if you like) to clean up formatting

@brenzi brenzi closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants