Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip lists: Remove implicit pytest.skip() in UT, migrate to pytest-select configurations #882

Closed
vlad-penkin opened this issue Apr 16, 2024 · 3 comments · Fixed by #876
Closed
Assignees
Labels
Milestone

Comments

@vlad-penkin
Copy link
Contributor

This ticket consists of two task groups:

  • Skip lists feature implementation and it's integration in local UT test runner script and CI workflows
  • Actual tests code clean up and skip tests configuration creation

PR for first task group is

@AshburnLee
Copy link
Contributor

AshburnLee commented Jun 17, 2024

@vlad-penkin I may need some clarification.

  1. There are two items in the description, and the 1st one is merged, so I think I need to solve the 2nd one, right?

  2. "Actual tests code clean up and skip tests configuration creation"

    • "tests code clean up": Are you sure that we remove "pytest.skip()" in all test scripts? I thought we are not supposed to modified the source code.
    • "skip tests configuration": Is this configuration like a "pytest.ini" or "pytest.ini.toml"?

@AshburnLee
Copy link
Contributor

AshburnLee commented Jun 21, 2024

From what I understand, the aim is replacing 'pytest.skip()' using deselect list.

We have many platforms, platformA, platformB, platformC. for a single case that is coded as

...
if capability[0] < 9 and (ADTYPE == "float8e4nv" or BDTYPE == "float8e4nv"):
    pytest.skip("Only test float8e4nv on devices with sm >= 90")
...

This case could be SKIPPED(platformA), PASSED(platformB), FAILED(platfromC).

SKIPPED(platformA), expected, so put it in to skiplist of platfromA. those cases will not be detected (saving time)
PASSED(platformB), expected, do noting.
FAILED(platfromC), unexpected, so put it in to skiplist of platfromC and track it.

So before change any code, we

  1. step1, run all tests, and collect skiplist for every platform.
  2. step2, remove 'pytest.skip()' .

@AshburnLee
Copy link
Contributor

As discussed with Vlad, close this one, and put the request into #1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants