From 1c13e6f5e6bae9df42b483852c60631609422043 Mon Sep 17 00:00:00 2001 From: Nick Sarnie Date: Fri, 12 Jul 2024 07:43:50 -0700 Subject: [PATCH] [SYCL][ClangLinkerWrapper] Unconditionally pass -properties to sycl-post-link (#14541) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the old offloading model we have an indirect target dependency because -properties is mutually exclusive with -ir-output-only, and the later option does depend on the triple. However in the new offloading model we currently don’t ever pass -ir-output-only, so we should always be able to pass -properties, at least for now. Signed-off-by: Sarnie, Nick --- clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp index c0def22c4147f..57273b022dbae 100644 --- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp +++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp @@ -545,8 +545,9 @@ getTripleBasedSYCLPostLinkOpts(const ArgList &Args, else PostLinkArgs.push_back("-spec-const=emulation"); - if (Triple.isSPIROrSPIRV() || SYCLNativeCPU) - PostLinkArgs.push_back("-properties"); + // TODO: If we ever pass -ir-output-only based on the triple, + // make sure we don't pass -properties. + PostLinkArgs.push_back("-properties"); // See if device code splitting is already requested. If not requested, then // set -split=auto for non-FPGA targets.