From 5f1d98a6e9da8065e8c211479113385ff16cd71b Mon Sep 17 00:00:00 2001 From: Vyacheslav Klochkov Date: Wed, 7 Feb 2024 15:04:47 -0600 Subject: [PATCH] [ESIMD][E2E] Enable few cases in atomic_update after gpu driver update (#12639) Signed-off-by: Klochkov, Vyacheslav N --- .../Inputs/atomic_update.hpp | 16 ++++---------- .../Inputs/atomic_update_slm.hpp | 22 +++---------------- 2 files changed, 7 insertions(+), 31 deletions(-) diff --git a/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp b/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp index 3da82ee8e15d1..ef8646ae4892a 100644 --- a/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp +++ b/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp @@ -715,13 +715,10 @@ bool test_int_types_and_sizes(queue q, const Config &cfg) { q, cfg); passed &= test_int_types<64, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>( q, cfg); - // non power of two values are supported only in newer driver. - // TODO: Enable this when the new driver reaches test infrastructure - // (v27556). -#if 0 - passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg); - passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>(q, cfg); -#endif + passed &= test_int_types<12, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>( + q, cfg); + passed &= test_int_types<33, Op, UseMask, UseLSCFeatures, UseAcc, SignMask>( + q, cfg); } return passed; @@ -742,13 +739,8 @@ bool test_fp_types_and_sizes(queue q, const Config &cfg) { passed &= test_fp_types<32, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg); passed &= test_fp_types<64, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg); - // non power of two values are supported only in newer driver. - // TODO: Enable this when the new driver reaches test infrastructure - // (v27556). -#if 0 passed &= test_fp_types<12, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg); passed &= test_fp_types<35, Op, UseMask, UseLSCFeatures, UseAcc>(q, cfg); -#endif } return passed; } diff --git a/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp b/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp index 92f000711e137..6b69d99158cb6 100644 --- a/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp +++ b/sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update_slm.hpp @@ -612,14 +612,9 @@ bool test_fp_types(queue q) { if constexpr (Features == TestFeatures::DG2 || Features == TestFeatures::PVC) { - // TODO: fmin/fmax/fcmpxchg for double requires a newer GPU driver. - if constexpr (!std::is_same_v, ImplLSCFmax> && - !std::is_same_v, ImplLSCFmin> && - !std::is_same_v, ImplLSCFcmpwr>) { - if (q.get_device().has(sycl::aspect::atomic64) && - q.get_device().has(sycl::aspect::fp64)) { - passed &= run_test(q); - } + if (q.get_device().has(sycl::aspect::atomic64) && + q.get_device().has(sycl::aspect::fp64)) { + passed &= run_test(q); } } return passed; @@ -633,7 +628,6 @@ bool test_int_types_and_sizes(queue q) { passed &= test_int_types<2, Op, UseMask, Features, UseAcc, SignMask>(q); passed &= test_int_types<4, Op, UseMask, Features, UseAcc, SignMask>(q); passed &= test_int_types<8, Op, UseMask, Features, UseAcc, SignMask>(q); - // TODO: N=16 and N=32 does not pass on Gen12 with mask due to older driver. if (UseMask && Features == TestFeatures::Generic && esimd_test::isGPUDriverGE(q, esimd_test::GPUDriverOS::LinuxAndWindows, "26918", "101.4953", false)) { @@ -645,13 +639,8 @@ bool test_int_types_and_sizes(queue q) { if constexpr (Features == TestFeatures::DG2 || Features == TestFeatures::PVC) { passed &= test_int_types<64, Op, UseMask, Features, UseAcc, SignMask>(q); - // non power of two values are supported only in newer driver. - // TODO: Enable this when the new driver reaches test infrastructure - // (v27556). -#if 0 passed &= test_int_types<12, Op, UseMask, Features, UseAcc, SignMask>(q); passed &= test_int_types<33, Op, UseMask, Features, UseAcc, SignMask>(q); -#endif } return passed; @@ -672,13 +661,8 @@ bool test_fp_types_and_sizes(queue q) { if constexpr (Features == TestFeatures::DG2 || Features == TestFeatures::PVC) { passed &= test_fp_types<64, Op, UseMask, Features, UseAcc>(q); - // non power of two values are supported only in newer driver. - // TODO: Enable this when the new driver reaches test infrastructure - // (v27556). -#if 0 passed &= test_fp_types<33, Op, UseMask, Features, UseAcc>(q); passed &= test_fp_types<65, Op, UseMask, Features, UseAcc>(q); -#endif } return passed; }