From d96ebeed82aa5d02214bb4106450ff3a8fc21cd6 Mon Sep 17 00:00:00 2001
From: Dounia <dounia.khaldi@intel.com>
Date: Tue, 20 Feb 2024 11:32:27 -0800
Subject: [PATCH] Address Greg's comments: Store API matching and fix argument
 name

---
 .../sycl_ext_intel_matrix.asciidoc             | 18 ++++++++++++------
 .../sycl_ext_oneapi_matrix.asciidoc            |  4 ++--
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_intel_matrix.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_intel_matrix.asciidoc
index fabc56ea5034c..b76a8b2292f78 100644
--- a/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_intel_matrix.asciidoc
+++ b/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_intel_matrix.asciidoc
@@ -148,21 +148,27 @@ template <typename Group, typename T, size_t Rows, size_t Cols,
           access::decorated IsDecorated>
 void joint_matrix_store(Group g,
     const joint_matrix<Group, T, use::a, Rows, Cols, Layout> &res,
-    multi_ptr<T, Space, IsDecorated> src, size_t stride);
+    multi_ptr<T, Space, IsDecorated> dest, size_t stride);
 
 template <typename Group, typename T, size_t Rows, size_t Cols,
           layout Layout, access::address_space Space,
           access::decorated IsDecorated>
 void joint_matrix_store(Group g,
     const joint_matrix<Group, T, use::b, Rows, Cols, Layout> &res,
-    multi_ptr<T, Space, IsDecorated> src, size_t stride);
+    multi_ptr<T, Space, IsDecorated> dest, size_t stride);
 
-// Only available when Layout != layout::dynamic
 template <typename Group, typename T, size_t Rows, size_t Cols,
-          use Use, layout Layout, typename PropertyListT>
+          layout Layout, typename PropertyListT>
 void joint_matrix_store(Group g,
-    joint_matrix<Group, T, Use, Rows, Cols, Layout> &res,
-    ext::oneapi::experimental::annotated_ptr<T, PropertyListT> src,
+    const joint_matrix<Group, T, use::a, Rows, Cols, Layout> &res,
+    ext::oneapi::experimental::annotated_ptr<T, PropertyListT> dest,
+    size_t stride);
+
+template <typename Group, typename T, size_t Rows, size_t Cols,
+          layout Layout, typename PropertyListT>
+void joint_matrix_store(Group g,
+    const joint_matrix<Group, T, use::b, Rows, Cols, Layout> &res,
+    ext::oneapi::experimental::annotated_ptr<T, PropertyListT> dest,
     size_t stride);
 
 } // namespace sycl::ext::intel::experimental::matrix
diff --git a/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc
index 20bcab29eb270..1af6f7a72de88 100644
--- a/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc
+++ b/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc
@@ -320,7 +320,7 @@ written in a row (`row_major`), column major (`col_major`)
 fashion. `stride` describes the number of elements between consecutive
 rows for the row major layout, or between columns for the column major layout.
 
-The overload of `joint_matrix_store` takes
+The second overload of `joint_matrix_store` takes
 `sycl::ext::oneapi::experimental::annotated_ptr` as argument instead
 of `sycl::multi_ptr`. The property list associated with the
 `annotated_ptr` argument represents the compile-time constant
@@ -433,7 +433,7 @@ joint_matrix_apply(sg, C, [=](T &x) {
 namespace sycl::ext::oneapi::experimental::matrix {
 
 template <size_t Rows, size_t Cols, typename Group, typename T,
-          typename Properties = ext::oneapi::experimental::empty_properties_t>
+          typename Properties = empty_properties_t>
 void joint_matrix_prefetch(Group g, T* ptr, size_t stride, layout Layout,
                            Properties properties = {});